RFR: 8266337: ThreadTimesClosure doesn't handle exceptions properly [v2]

Leonid Mesnik lmesnik at openjdk.java.net
Wed Jun 2 21:59:42 UTC 2021


On Wed, 2 Jun 2021 01:20:48 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> 8266337: ThreadTimesClosure doesn't handle exceptions properly
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   strdup_check_oom is used instead of strdup.

I believe that it is safer to use strdup_check_oom anywhere except error handling. The plain strdup might cause delayed SEGV hard to diagnose. Might be it makes sense to file another RFE to review strdup usage.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4292


More information about the serviceability-dev mailing list