RFR: 8266337: ThreadTimesClosure doesn't handle exceptions properly [v2]

[David Holmes]

On Wed, 2 Jun 2021 01:20:48 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> 8266337: ThreadTimesClosure doesn't handle exceptions properly
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   strdup_check_oom is used instead of strdup.

I don't think there is any practical difference between strdup and strdup_check_oom - the chances that we exhaust the C heap just as we hit this call are extremely low, and no matter what we do here the VM is dying if that happens (we may not even have enough memory to call vm_exit_out_of_memory!). The use of strdup_check_oom is at least cleaner as we don't have any issues with not checking the return value from strdup if a static checker looks at this code.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4292