RFR: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case

Serguei Spitsyn sspitsyn at openjdk.java.net
Thu Jun 10 14:46:58 UTC 2021


On Thu, 10 Jun 2021 10:26:46 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this small fix for `serviceability/logging/TestFullNames.java` test?
> from JBS:
>> serviceability/logging/TestFullNames.java test contains two test cases: specifying filename w/ and w/o "file=" prefix. yet, the test doesn't remove the file, hence its 2nd test case doesn't really test much.
> 
> the patch simply calls `File::delete` inside the loop and verifies that the file doesn't exist at the beginning of each iteration.
> 
> testing: `serviceability/logging/TestFullNames.java` on `{linux,windows,macosx}-x64`
> 
> Thanks,
> -- Igor

Marked as reviewed by sspitsyn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4461


More information about the serviceability-dev mailing list