RFR: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case

Igor Ignatyev iignatyev at openjdk.java.net
Thu Jun 10 10:33:21 UTC 2021


Hi all,

could you please review this small fix for `serviceability/logging/TestFullNames.java` test?
from JBS:
> serviceability/logging/TestFullNames.java test contains two test cases: specifying filename w/ and w/o "file=" prefix. yet, the test doesn't remove the file, hence its 2nd test case doesn't really test much.

the patch simply calls `File::delete` inside the loop and verifies that the file doesn't exist at the beginning of each iteration.

testing: `serviceability/logging/TestFullNames.java` on `{linux,windows,macosx}-x64`

Thanks,
-- Igor

-------------

Commit messages:
 - 8268542

Changes: https://git.openjdk.java.net/jdk/pull/4461/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4461&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268542
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4461.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4461/head:pull/4461

PR: https://git.openjdk.java.net/jdk/pull/4461


More information about the serviceability-dev mailing list