Integrated: 8268539: several serviceability/sa tests should be run in driver mode

Igor Ignatyev iignatyev at openjdk.java.net
Thu Jun 10 17:08:58 UTC 2021


On Thu, 10 Jun 2021 10:07:48 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this _test-only_ patch that switches the execution mode of several `serviceability/sa` tests to `driver`? all these tests seem not to perform actual testing, and just organize other JDK executions and validates their outputs.
> 
> `ClhsdbDumpclass.java` had to be updated to have access to `./jdk/test/lib/apps/LingeredApp.class` file. Although this also can be fixed by propagating the classpath setting to `javap`, using the path to `.class` file is more clear and relable, and I actually suspect that before `javap` read not the dumped `.class` file, but the one from the test's classpath.
> 
> Thanks,
> -- Igor

This pull request has now been integrated.

Changeset: 78cb6776
Author:    Igor Ignatyev <iignatyev at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/78cb6776b6d43b67457993a109719b36ee892d60
Stats:     40 lines in 23 files changed: 0 ins; 0 del; 40 mod

8268539: several serviceability/sa tests should be run in driver mode

Reviewed-by: sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/4460


More information about the serviceability-dev mailing list