RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out [v10]

[Lin Zang]

On Thu, 13 May 2021 20:23:10 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into s-fix
>>  - fix typo in comments
>>  - Merge branch 'master' into s-fix
>>  - Merge branch 'master'
>>  - Merge branch 'master' into sf
>>  - rename writeThrough to unbufferedMode and code refine
>>  - fix typo in comments
>>  - Merge branch 'master' into sf
>>  - Revert "reduce memory consumption"
>>    
>>    This reverts commit 70e43ddd453724ce36bf729fa6489c0027957b8e.
>>  - reduce memory consumption
>>  - ... and 2 more: https://git.openjdk.java.net/jdk/compare/a02b1f29...6fde07bd
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java line 1528:
> 
>> 1526:             }
>> 1527:             writeInteger(0);
>> 1528:             writeInteger(size);
> 
> You've added `writeInteger(size)` here, but I'm not sure where this used to be done.

There used to be 2 writeInterger(0), and the second one is write the segment size with dummy value 0. I will add a comment here. Thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/2803