RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out [v10]

[Chris Plummer]

On Fri, 14 May 2021 02:08:13 GMT, Lin Zang <lzang at openjdk.org> wrote:

>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java line 1528:
>> 
>>> 1526:             }
>>> 1527:             writeInteger(0);
>>> 1528:             writeInteger(size);
>> 
>> You've added `writeInteger(size)` here, but I'm not sure where this used to be done.
>
> There used to be 2 writeInterger(0), and the second one is write the segment size with dummy value 0. I will add a comment here. Thanks

Ok, I missed that. I think where a comment is needed is with the first `writerInteger(0)`. It's not clear to me what that one is for.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2803