RFR: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

Thomas Stuefe stuefe at openjdk.java.net
Thu Nov 4 05:16:15 UTC 2021


On Wed, 3 Nov 2021 19:19:11 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> It's actually fairly common to have Mac-specific stuff in the BSD files. The macOS port was built on top of the BSD port and the BSD port was built by copying a LOT of code from Linux into BSD specific files with modifications as needed.

I always wondered whether anyone actually builds the BSDs in head. I assume Oracle does not, right? I know there are downstream porters somewhere but only for old releases, or?

> 
> If I pushed this change down into MachDecoder, then I would have to lose the `ShouldNotReachHere()` call in order to not assert in non-release bits. I don't think I want to do that since this may not be the only place that calls the 6-arg version of decode().

Fair enough, thanks for the clarification.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6193


More information about the serviceability-dev mailing list