RFR: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

[Daniel D.Daugherty]

On Thu, 4 Nov 2021 05:12:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> It's actually fairly common to have Mac-specific stuff in the BSD files. The macOS
>> port was built on top of the BSD port and the BSD port was built by copying a LOT
>> of code from Linux into BSD specific files with modifications as needed.
>> 
>> If I pushed this change down into MachDecoder, then I would have to lose the
>> `ShouldNotReachHere()` call in order to not assert in non-release bits. I don't
>> think I want to do that since this may not be the only place that calls the
>> 6-arg version of decode().
>
>> It's actually fairly common to have Mac-specific stuff in the BSD files. The macOS port was built on top of the BSD port and the BSD port was built by copying a LOT of code from Linux into BSD specific files with modifications as needed.
> 
> I always wondered whether anyone actually builds the BSDs in head. I assume Oracle does not, right? I know there are downstream porters somewhere but only for old releases, or?
> 
>> 
>> If I pushed this change down into MachDecoder, then I would have to lose the `ShouldNotReachHere()` call in order to not assert in non-release bits. I don't think I want to do that since this may not be the only place that calls the 6-arg version of decode().
> 
> Fair enough, thanks for the clarification.

Oracle does not build BSD in head. At one point, Dmitry Samersoff used to build BSD
in his lab, but I don't know if he still does that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6193