RFR: 8292006: Move thread accessor classes to threadJavaClasses.hpp

[Thomas Stuefe]

On Sat, 6 Aug 2022 00:11:08 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> To improve modularity and build time, move the declaration of the following accessor from classfile/javaClasses.hpp to runtime/threadJavaClasses.hpp:
> 
> + java_lang_Thread_FieldHolder
> + java_lang_Thread_Constants
> + java_lang_ThreadGroup
> + java_lang_VirtualThread
> 
> Also move javaThreadStatus.hpp from share/classfile to share/runtime, where it belongs.

Hi Ioi,

looks good. Small nits inline. I did not check that the moved code is identical, because I assume you just moved it around unchanged.

Cheers, Thomas

src/hotspot/share/runtime/threadJavaClasses.cpp line 36:

> 34: #include "runtime/threadJavaClasses.hpp"
> 35: #include "runtime/threadSMR.hpp"
> 36: #include "runtime/vframe.inline.hpp"

needs debug.hpp and macros.hpp, at least, to be self-contained. Probably globalDefinitions.hpp too.

src/hotspot/share/runtime/threadJavaClasses.hpp line 31:

> 29: #include "memory/allStatic.hpp"
> 30: #include "oops/oopsHierarchy.hpp"
> 31: #include "runtime/os.hpp"

Where do you need os.hpp?

src/hotspot/share/runtime/threadJavaClasses.inline.hpp line 32:

> 30: #include "oops/instanceKlass.inline.hpp"
> 31: #include "oops/oop.inline.hpp"
> 32: #include "oops/oopsHierarchy.hpp"

I believe that for INCLUDE_JFR you need macros.hpp, or? Highly likely it's already there, or you'd get linker errors. But it should be explicit.

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9788