RFR: 8292006: Move thread accessor classes to threadJavaClasses.hpp

David Holmes dholmes at openjdk.org
Sun Aug 7 22:16:43 UTC 2022


On Sat, 6 Aug 2022 13:09:01 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> To improve modularity and build time, move the declaration of the following accessor from classfile/javaClasses.hpp to runtime/threadJavaClasses.hpp:
>> 
>> + java_lang_Thread_FieldHolder
>> + java_lang_Thread_Constants
>> + java_lang_ThreadGroup
>> + java_lang_VirtualThread
>> 
>> Also move javaThreadStatus.hpp from share/classfile to share/runtime, where it belongs.
>
> src/hotspot/share/runtime/threadJavaClasses.inline.hpp line 32:
> 
>> 30: #include "oops/instanceKlass.inline.hpp"
>> 31: #include "oops/oop.inline.hpp"
>> 32: #include "oops/oopsHierarchy.hpp"
> 
> I believe that for INCLUDE_JFR you need macros.hpp, or? Highly likely it's already there, or you'd get linker errors. But it should be explicit.

It is included in the .hpp file as it should be.

-------------

PR: https://git.openjdk.org/jdk/pull/9788


More information about the serviceability-dev mailing list