RFR: 8298380: Clean up redundant array length checks in JDK code base

David Holmes dholmes at openjdk.org
Fri Dec 9 00:14:49 UTC 2022


On Thu, 8 Dec 2022 12:37:17 GMT, Sergey Tsypanov <stsypanov at openjdk.org> wrote:

> Newer version of IntelliJ IDEA introduces new [inspection](https://youtrack.jetbrains.com/issue/IDEA-301797/IDEA-should-report-redundant-array-length-check-in-certain-cases) detecting redundant array length check in snippets like
> 
> <T> void iterate(T[] items) {
>   if (items.length == 0) {
>     return;
>   }
>   for (T item : items) {
>     //...
>   }
> }
> 
> Here
> 
> if (items.length == 0) {
>   return;
> }
> 
> is redundant and can be removed as length check is performed by for-each loop.

These all seem fine to me.

You can count this as the review for hotspot and serviceability. :)

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11589


More information about the serviceability-dev mailing list