RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987

[Chris Plummer]

On Wed, 19 Jan 2022 04:28:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Hi Chris,
> 
> Your links to JDK-8269232 actually go to the wrong bug.

Ok. Fixed.

> src/jdk.jdwp.agent/share/native/libjdwp/commonRef.c line 532:
> 
>> 530:             jobject strongRef;
>> 531: 
>> 532:             strongRef = strengthenNode(env, node, JNI_FALSE);
> 
> Can you comment the JNI_FALSE parameter in these calls please e.g.
> 
> strongRef = strengthenNode(env, node, JNI_FALSE /* not pinAll */);

ok

> src/jdk.jdwp.agent/share/native/libjdwp/util.h line 69:
> 
>> 67:     jint         count;         /* count of references */
>> 68:     jboolean     isStrong;      /* true if this is a strong reference. Either or both of isPinAll
>> 69:                                    and isCommonPin will also be true */
> 
> Doesn't that mean we don't need the `isStrong` field but rather:
> 
> jboolean isStrong() { return isPinAll || isCommonPin; }
> 
> ?

I considered doing that. I can still make that change if you think it would be better.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7134