RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987

David Holmes dholmes at openjdk.java.net
Wed Jan 19 05:47:32 UTC 2022


On Wed, 19 Jan 2022 04:41:30 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> src/jdk.jdwp.agent/share/native/libjdwp/util.h line 69:
>> 
>>> 67:     jint         count;         /* count of references */
>>> 68:     jboolean     isStrong;      /* true if this is a strong reference. Either or both of isPinAll
>>> 69:                                    and isCommonPin will also be true */
>> 
>> Doesn't that mean we don't need the `isStrong` field but rather:
>> 
>> jboolean isStrong() { return isPinAll || isCommonPin; }
>> 
>> ?
>
> I considered doing that. I can still make that change if you think it would be better.

I think it would be simpler/clearer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7134


More information about the serviceability-dev mailing list