RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987
Chris Plummer
cjplummer at openjdk.java.net
Wed Jan 19 06:01:28 UTC 2022
On Wed, 19 Jan 2022 04:40:57 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/commonRef.c line 532:
>>
>>> 530: jobject strongRef;
>>> 531:
>>> 532: strongRef = strengthenNode(env, node, JNI_FALSE);
>>
>> Can you comment the JNI_FALSE parameter in these calls please e.g.
>>
>> strongRef = strengthenNode(env, node, JNI_FALSE /* not pinAll */);
>
> ok
I though normally we just gave the name of the argument in the comment, and not apply the value. So in the above case we would use `JNI_FALSE /* pinAll */`.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7134
More information about the serviceability-dev
mailing list