RFR: 8288214: serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java test failed [v2]

[Serguei Spitsyn]

On Mon, 13 Jun 2022 18:04:34 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> This test connects to http://openjdk.java.net/ so it's not reliable if the host name can't be resolved or a HTTP connection cannot be established. I've changed the test to use a local HTTP server so the original test works as before, it's just a local rather than remote HTTP connection.
>> 
>> I did a few cleanups to the test while I was there:
>> - changed the test to use `@enablePreview`.
>> - renamed "VThread" in the comment to "virtual thread".
>> - changed the test to use Executors.newVirtualThreadPerTaskExecutor to avoid needing to specify a ThreadFactory.
>> - add a call Future::get so that if the virtual thread terminates with an exception then the test will fail quickly, avoids needing to calling into the native/agent code to check if it passed.
>
> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo in comment. Emit trace output before bytes are consumed

It looks good.
Thank you for fixing it!
-Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/6