Integrated: 8288214: serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java test failed
Alan Bateman
alanb at openjdk.java.net
Tue Jun 14 13:04:00 UTC 2022
On Sat, 11 Jun 2022 08:11:34 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> This test connects to http://openjdk.java.net/ so it's not reliable if the host name can't be resolved or a HTTP connection cannot be established. I've changed the test to use a local HTTP server so the original test works as before, it's just a local rather than remote HTTP connection.
>
> I did a few cleanups to the test while I was there:
> - changed the test to use `@enablePreview`.
> - renamed "VThread" in the comment to "virtual thread".
> - changed the test to use Executors.newVirtualThreadPerTaskExecutor to avoid needing to specify a ThreadFactory.
> - add a call Future::get so that if the virtual thread terminates with an exception then the test will fail quickly, avoids needing to calling into the native/agent code to check if it passed.
This pull request has now been integrated.
Changeset: c76a06ae
Author: Alan Bateman <alanb at openjdk.org>
URL: https://git.openjdk.org/jdk19/commit/c76a06aeb5fe7d7630736a74aad8c873b7afe36b
Stats: 58 lines in 2 files changed: 39 ins; 4 del; 15 mod
8288214: serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java test failed
Reviewed-by: lmesnik, zgu, dcubed, sspitsyn
-------------
PR: https://git.openjdk.org/jdk19/pull/6
More information about the serviceability-dev
mailing list