RFR: 8288752: Split thread implementation files [v7]

[Daniel D. Daugherty]

On Tue, 21 Jun 2022 23:02:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This changes splits thread.hpp/cpp into javaThread, and threads files.
>> 
>> I left the commits intact to see better the progression of changes, but most files are include file changes.  The only tricky parts are that some files were included in thread.hpp, like mutexLocker.cpp, which has to be included in the files that need it.
>> 
>> I didn't update the copyrights to save diffs but will before integration.
>> Also I won't integrate until after Dan's JDK 19 changes are merged into JDK 20.
>> 
>> Tested with tier1-4 on Oracle supported platforms and built on other platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More GHA fixes.

Sorry for the late review. I decided to try a crawl-thru review with this PR
and managed to get 1/3 done yesterday and the rest done today.

I very much like this PR. I think there's only one comment that will require a cleanup.

src/hotspot/cpu/zero/stack_zero.cpp line 29:

> 27: #include "interpreter/interpreterRuntime.hpp"
> 28: #include "interpreter/zero/bytecodeInterpreter.hpp"
> 29: #include "runtime/javaThread.hpp"

Interesting... This replacement of thread.inline.hpp to javaThread.hpp also
has an include javaThread.inline.hpp. There are other thread.inline.hpp to
javaThread.hpp replacements that don't add an include of javaThread.inline.hpp.

Did you only add javaThread.inline.hpp when compilation failed?

src/hotspot/share/prims/jvmtiDeferredUpdates.hpp line 36:

> 34: template <typename T> class GrowableArray;
> 35: 
> 36: class jvmtiDeferredLocalVariable : public CHeapObj<mtCompiler> {

This surprised me, but I'm guessing we picked up the template
from thread.inline.hpp...

src/hotspot/share/runtime/interfaceSupport.inline.hpp line 39:

> 37: #include "runtime/safepointMechanism.inline.hpp"
> 38: #include "runtime/safepointVerifiers.hpp"
> 39: #include "runtime/javaThread.inline.hpp"

This is a duplicate include of the one on L33 above.

src/hotspot/share/runtime/vframe.hpp line 116:

> 114: };
> 115: 
> 116: class MonitorInfo;

This one also surprise me. I don't have a guess how this one worked before.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9218