RFR: 8288752: Split thread implementation files [v7]

Coleen Phillimore coleenp at openjdk.org
Wed Jun 22 21:04:40 UTC 2022


On Wed, 22 Jun 2022 19:06:35 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More GHA fixes.
>
> src/hotspot/share/prims/jvmtiDeferredUpdates.hpp line 36:
> 
>> 34: template <typename T> class GrowableArray;
>> 35: 
>> 36: class jvmtiDeferredLocalVariable : public CHeapObj<mtCompiler> {
> 
> This surprised me, but I'm guessing we picked up the template
> from thread.inline.hpp...

yes.

> src/hotspot/share/runtime/vframe.hpp line 116:
> 
>> 114: };
>> 115: 
>> 116: class MonitorInfo;
> 
> This one also surprise me. I don't have a guess how this one worked before.

That forward declaration came from a transitive include of thread.hpp, if I remember correctly.

-------------

PR: https://git.openjdk.org/jdk/pull/9218


More information about the serviceability-dev mailing list