RFR: 8288752: Split thread implementation files [v7]

Coleen Phillimore coleenp at openjdk.org
Wed Jun 22 21:09:39 UTC 2022


On Tue, 21 Jun 2022 23:38:23 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More GHA fixes.
>
> src/hotspot/cpu/zero/stack_zero.cpp line 29:
> 
>> 27: #include "interpreter/interpreterRuntime.hpp"
>> 28: #include "interpreter/zero/bytecodeInterpreter.hpp"
>> 29: #include "runtime/javaThread.hpp"
> 
> Interesting... This replacement of thread.inline.hpp to javaThread.hpp also
> has an include javaThread.inline.hpp. There are other thread.inline.hpp to
> javaThread.hpp replacements that don't add an include of javaThread.inline.hpp.
> 
> Did you only add javaThread.inline.hpp when compilation failed?

Yes, I added javaThread.inline.hpp after compilation failed.  I will remove javaThread.hpp.

> src/hotspot/share/runtime/interfaceSupport.inline.hpp line 39:
> 
>> 37: #include "runtime/safepointMechanism.inline.hpp"
>> 38: #include "runtime/safepointVerifiers.hpp"
>> 39: #include "runtime/javaThread.inline.hpp"
> 
> This is a duplicate include of the one on L33 above.

Thanks, that was unintentional.  Removed.

-------------

PR: https://git.openjdk.org/jdk/pull/9218


More information about the serviceability-dev mailing list