RFR: 8289230: Move PlatformXXX class declarations out of os_xxx.hpp [v2]

[Ioi Lam]

On Tue, 28 Jun 2022 19:37:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed comments
>
> src/hotspot/share/runtime/mutex.hpp line 203:
> 
>> 201:   #ifndef PRODUCT
>> 202:     void print_on(outputStream* st) const;
>> 203:     void print() const                      { /*print_on(::tty); */ } // FIXME
> 
> Can you move this print implementation into the .cpp file?

Fixed.

> src/hotspot/share/runtime/threadCrashProtection.hpp line 42:
> 
>> 40: #else
>> 41: # error "No ThreadCrashProtection implementation provided for this OS"
>> 42: #endif
> 
> Shouldn't you use this?
> #define OS_HEADER(basename)            XSTR(OS_HEADER_STEM(basename).hpp)

I fixed it as you suggested. I also fixed semaphore.hpp where I copied the old pattern from.

-------------

PR: https://git.openjdk.org/jdk/pull/9303