RFR: 8289230: Move PlatformXXX class declarations out of os_xxx.hpp [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Jun 28 21:10:43 UTC 2022


On Tue, 28 Jun 2022 20:08:18 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/runtime/threadCrashProtection.hpp line 42:
>> 
>>> 40: #else
>>> 41: # error "No ThreadCrashProtection implementation provided for this OS"
>>> 42: #endif
>> 
>> Shouldn't you use this?
>> #define OS_HEADER(basename)            XSTR(OS_HEADER_STEM(basename).hpp)
>
> I fixed it as you suggested. I also fixed semaphore.hpp where I copied the old pattern from.

Doesn't the OS_HEADER() -similar macro that handles the posix case too? I don't see it though.

-------------

PR: https://git.openjdk.org/jdk/pull/9303


More information about the serviceability-dev mailing list