RFR: 8282475: SafeFetch should not rely on existence of Thread::current [v5]

Johannes Bechberger duke at openjdk.java.net
Wed Mar 9 08:20:05 UTC 2022


On Tue, 8 Mar 2022 13:17:29 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> The WXMode for the current thread (on MacOS aarch64) is currently stored in the thread class which is unnecessary as the WXMode is bound to the current OS thread, not the current instance of the thread class.
>> This pull request moves the storage of the current WXMode into a thread local global variable in `os` and changes all related code. SafeFetch depended on the existence of a thread object only because of the WXMode. This pull request therefore removes the dependency, making SafeFetch usable in more contexts.
>
> Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
> 
>  - Move code to os::current_thread_wx
>  - Small fixes
>  - Move WX functionality into os specific files
>  - Minor fixes
>  - Fix include for threadWXSetters.inline.hpp
>  - Remove thread parameter from ThreadWXEnable
>  - Remove thread parameter from os methods
>  - Remove wx_init and current thread assert in safefetch
>  - Use os::current_thread_change_wx instead of thread methods

Oh, I did not know that. Sorry for that, I just wanted to rebase it and forgot that this would change all the commit ids.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7727


More information about the serviceability-dev mailing list