RFR: 8282475: SafeFetch should not rely on existence of Thread::current [v5]

Thomas Stuefe stuefe at openjdk.java.net
Wed Mar 9 08:40:07 UTC 2022


On Wed, 9 Mar 2022 08:16:51 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

> Oh, I did not know that. Sorry for that, I just wanted to rebase it and forgot that this would change all the commit ids.

You couldn't know. Just merge "master", which achieves the same and leaves the history intact.

Additional tip. You can start a PR in draft mode. Reviews won't start until you un-draft. In draft mode, you have plenty of time to flesh out the patch and fix all bugs that show up in GHAs. In that phase, it's still okay to rebase. Once you consider the patch ready, you can un-draft the PR and the reviews start. Only then you should not rebase anymore.

Starting out with a draft PR has also the advantage of not using reviewer time on an incomplete patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7727


More information about the serviceability-dev mailing list