RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Apr 21 06:08:43 UTC 2023


On Thu, 20 Apr 2023 18:17:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressed review comments on new test
>
> src/hotspot/share/prims/jvmtiEnv.cpp line 1197:
> 
>> 1195:   if (is_virtual && !is_JavaThread_current(java_thread, thread_oop)) {
>> 1196:     if (!JvmtiVTSuspender::is_vthread_suspended(thread_oop)) {
>> 1197:       return JVMTI_ERROR_THREAD_NOT_SUSPENDED;
> 
> Does JvmtiVTSuspender::is_vthread_suspended work for the alternative virtual thread implementation (-XX:+VMContinuations)?

Nice catch - fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1173336527


More information about the serviceability-dev mailing list