RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

Alan Bateman alanb at openjdk.org
Fri Apr 21 17:15:47 UTC 2023


On Fri, 21 Apr 2023 06:06:16 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiEnv.cpp line 1197:
>> 
>>> 1195:   if (is_virtual && !is_JavaThread_current(java_thread, thread_oop)) {
>>> 1196:     if (!JvmtiVTSuspender::is_vthread_suspended(thread_oop)) {
>>> 1197:       return JVMTI_ERROR_THREAD_NOT_SUSPENDED;
>> 
>> Does JvmtiVTSuspender::is_vthread_suspended work for the alternative virtual thread implementation (-XX:-VMContinuations)?
>
> Nice catch - fixed now.

Okay but JvmtiVTMSTransitionDisabler prevent the thread from being resumed for the -XX:-VMContinuations case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1174002110


More information about the serviceability-dev mailing list