RFR: 8306034: add support of virtual threads to JVMTI StopThread [v6]

[Alan Bateman]

On Thu, 27 Apr 2023 18:49:40 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmti.xml line 11984:
>> 
>>> 11982:     <errorid id="JVMTI_ERROR_OPAQUE_FRAME" num="32">
>>> 11983:       Information about the frame is not available (e.g. for native frames),
>>> 11984:       or the frame is not suitable for the requested operation.
>> 
>> After re-reading the spec changes, I'm wondering if we can improve on "or the frame is not suitable for the requested operation".  StopThread doesn't have a frame parameter. ForceEarlyReturn doesn't have a frame parameter either as it's implicit (the current frame). I wonder if wording something like this might be better:
>> "or a function on a thread cannot be performed at the thread's current frame".
>
> The wording starts off with "Information about the frame...", and you haven't suggested to change that to "the current frame". We should be consistent. Can't we just change both "the frame" references to "the current frame", and leave the rest the same as what Serguei has in place here?

I think the first part is okay because it's for functions that are about frames. The NotifyFramePop specifies the depth so it may not be the current frame. The second usage is the functions on a thread where we might do better than "not suitable".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1179571945