RFR: 8306034: add support of virtual threads to JVMTI StopThread [v6]

Chris Plummer cjplummer at openjdk.org
Thu Apr 27 19:17:03 UTC 2023


On Thu, 27 Apr 2023 18:59:34 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> The wording starts off with "Information about the frame...", and you haven't suggested to change that to "the current frame". We should be consistent. Can't we just change both "the frame" references to "the current frame", and leave the rest the same as what Serguei has in place here?
>
> I think the first part is okay because it's for functions that are about frames. The NotifyFramePop specifies the depth so it may not be the current frame. The second usage is the functions on a thread where we might do better than "not suitable".

Ok. How about "the function cannot be performed on the thread's current frame". We already have a couple references to "the function" in the error codes section.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1179584919


More information about the serviceability-dev mailing list