RFR: 8306034: add support of virtual threads to JVMTI StopThread [v6]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Apr 28 00:56:24 UTC 2023
On Fri, 28 Apr 2023 00:46:23 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Ok. How about "the function cannot be performed on the thread's current frame". We already have a couple references to "the function" in the error codes section.
>
> We have two suggestions:
>> - "or a function on a thread cannot be performed at the thread's current frame".
>> - "the function cannot be performed on the thread's current frame."
>
> So, we need to pick one. The second one looks simpler to me but
> I'm not completely sure that it reflects the full meaning correctly.
> I wonder about a mix of the two suggestions above:
>
>> "the function cannot be performed at the thread's current frame."
We need to account for the `SetLocalXXX` functions with the `depth` parameter which also return `OPAQUE_FRAME` error code for virtual frames. My concern is if the "current frame" part is fully correct.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1179834952
More information about the serviceability-dev
mailing list