RFR: 8306034: add support of virtual threads to JVMTI StopThread [v6]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Apr 28 00:56:23 UTC 2023


On Thu, 27 Apr 2023 19:14:56 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> I think the first part is okay because it's for functions that are about frames. The NotifyFramePop specifies the depth so it may not be the current frame. The second usage is the functions on a thread where we might do better than "not suitable".
>
> Ok. How about "the function cannot be performed on the thread's current frame". We already have a couple references to "the function" in the error codes section.

We have two suggestions:
> - "or a function on a thread cannot be performed at the thread's current frame".
> - "the function cannot be performed on the thread's current frame."

So, we need to pick one. The second one looks simpler to me but
I'm not completely sure that it reflects the full meaning correctly.
I wonder about a mix of the two suggestions above:

> "the function cannot be performed at the thread's current frame."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1179833278


More information about the serviceability-dev mailing list