RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v3]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Apr 28 05:05:26 UTC 2023


On Thu, 27 Apr 2023 21:08:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Convert this ThreadReference.interrupt() test to support virtual threads. I believe this is the only test for ThreadReference.interrupt() that we have.
>> 
>> Tested by running with and without -Dmain.wrapper=Virtual on all supported platforms.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use NamedTask library class

Looks good.
Thanks,
Serguei

test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java line 214:

> 212:         }
> 213: 
> 214:         log2("......thread2 is " + (thread2.isVirtual() ? "" : "not ") + "a virtual thread");

Nit: Would it better to print "is a virtual thread" instead of "is not a virtual thread"?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13696#pullrequestreview-1405223335
PR Review Comment: https://git.openjdk.org/jdk/pull/13696#discussion_r1179927700


More information about the serviceability-dev mailing list