RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v3]

Chris Plummer cjplummer at openjdk.org
Fri Apr 28 06:00:53 UTC 2023


On Fri, 28 Apr 2023 04:56:17 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use NamedTask library class
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java line 214:
> 
>> 212:         }
>> 213: 
>> 214:         log2("......thread2 is " + (thread2.isVirtual() ? "" : "not ") + "a virtual thread");
> 
> Nit: Would it better to print "is a virtual thread" instead of "is not a virtual thread"?

I don't see your point. It prints one or the other depending on whether or not the thread is virtual.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13696#discussion_r1179956252


More information about the serviceability-dev mailing list