RFR: 8306851: Move Method access flags [v3]

[Coleen Phillimore]

On Fri, 28 Apr 2023 14:18:11 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove bool argument from ConstMethodFlags.set function.
>
> src/hotspot/share/oops/method.hpp line 615:
> 
>> 613:   // has not been computed yet.
>> 614:   bool guaranteed_monitor_matching() const       { return monitor_matching(); }
>> 615:   void set_guaranteed_monitor_matching()         { set_monitor_matching(); }
> 
> Is this method just obsolete now? If so it might be worth replacing the callers with `set_monitor_matching()` unless `set_monitor_matching()` is still meant to be private.

The reason I left that was to anchor the comment.  There is nowhere good to put that in the X macro.  Also, didn't want to fix the callers.  It's a good point about making monitor_matching() private, but also not really doable with the X macro.  So that's why I left it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13654#discussion_r1180548707