RFR: 8306851: Move Method access flags [v3]

[Frederic Parain]

On Thu, 27 Apr 2023 14:21:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change moves the flags from AccessFlags to either ConstMethodFlags or MethodFlags, depending on whether they are set at class file parse time, which makes them essentially const, or at runtime, which makes them needing atomic access.
>> 
>> This leaves AccessFlags int size because Klass still has JVM flags that are more work to move, but this change doesn't increase Method size.  I didn't remove JVM_RECOGNIZED_METHOD_MODIFIERS with this change since there are several of these in other places, and with this change the code is benign.
>> 
>> Tested with tier1-6, and some manual verification of printing.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove bool argument from ConstMethodFlags.set function.

Thank you for all those cleanings!
Looks good to me.

src/hotspot/share/oops/constMethod.cpp line 438:

> 436:   }
> 437:   st->cr();
> 438:   st->print(" - flags:             "); _flags.print_on(st);               st->cr();

Method prints its flags as an int and in decoded form, but ConstMethod only prints the decoded form. Any particular reason for this difference?

-------------

Marked as reviewed by fparain (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13654#pullrequestreview-1406421552
PR Review Comment: https://git.openjdk.org/jdk/pull/13654#discussion_r1180705106