RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v3]

David Holmes dholmes at openjdk.org
Thu Aug 31 01:38:01 UTC 2023


On Thu, 31 Aug 2023 00:07:19 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Test failed because of unexpected output of version string. 
>> The standard convention for tests is to skip any unexpected output (version string, VM warning, vm logging) and only fail on expected error patterns. 
>> Fix is tested by running with default options and  with '-showversion' vm option.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed unused code.

test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 103:

> 101: 
> 102:     @Override
> 103:     public void onStringRead(StreamHandler handler, String line) {

`handler` seems unused now as well. There was obviously some kind of grander design for this API that we now seem to be cutting off.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15499#discussion_r1310999238


More information about the serviceability-dev mailing list