RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v3]

Leonid Mesnik lmesnik at openjdk.org
Thu Aug 31 01:56:09 UTC 2023


On Thu, 31 Aug 2023 01:29:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed unused code.
>
> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 103:
> 
>> 101: 
>> 102:     @Override
>> 103:     public void onStringRead(StreamHandler handler, String line) {
> 
> `handler` seems unused now as well. There was obviously some kind of grander design for this API that we now seem to be cutting off.

Submitted https://github.com/openjdk/jdk/pull/15502

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15499#discussion_r1311009141


More information about the serviceability-dev mailing list