RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v8]

[Joachim Kern]

On Wed, 20 Dec 2023 23:10:29 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve error handling
>
> src/hotspot/os/aix/porting_aix.cpp line 25:
> 
>> 23:  */
>> 24: // needs to be defined first, so that the implicit loaded xcoff.h header defines
>> 25: // the right structures to analyze the loader header of 32 and 64 Bit executable files
> 
> I don't think we support 32 bit executables.

Originally my code worked for 32 & 64 Bit executables, but Thomas mentioned that we have only 64 Bit executables. So I removed the 32 Bit implementation, but this comment was an artefact. I removed the 32 Bit reference now.

> src/hotspot/os/aix/porting_aix.cpp line 921:
> 
>> 919: // If the libpath cannot be retrieved return an empty path
>> 920: static const char* rtv_linkedin_libpath() {
>> 921:   static char buffer[4096];
> 
> Maybe define a constant for the buffer size?

Done

> src/hotspot/os/aix/porting_aix.cpp line 927:
> 
>> 925:   // let libpath point to buffer, which then contains a valid libpath
>> 926:   // or an empty string
>> 927:   if (libpath) {
> 
> `!= nullptr` is common in hotspot.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433797348
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433801010
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433798833