RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v8]

[Joachim Kern]

On Wed, 20 Dec 2023 23:45:16 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   improve error handling
>
> src/hotspot/os/aix/porting_aix.cpp line 916:
> 
>> 914: constexpr int max_handletable = 1024;
>> 915: static int g_handletable_used = 0;
>> 916: static struct handletableentry g_handletable[max_handletable] = {{0, 0, 0, 0}};
> 
> Wouldn't `ConcurrentHashTable` be a better data structure? It is already used in hotspot, can grow dynamically and doesn't need linear search.

There will be only few libraries in the list. With this assumption Thomas suggested to use just a simple array.

> src/hotspot/os/aix/porting_aix.cpp line 990:
> 
>> 988:     }
>> 989:     ret = (0 == stat64x(combined.base(), stat));
>> 990:     os::free (path2);
> 
> Please remove the extra whitespace.

Done

> src/hotspot/os/aix/porting_aix.cpp line 1026:
> 
>> 1024: 
>> 1025:   os::free (libpath);
>> 1026:   os::free (path2);
> 
> Same here.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433813137
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433814446
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1433814755