RFR: 8301767: Convert virtual thread tests to JUnit [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Feb 8 09:25:46 UTC 2023
On Wed, 8 Feb 2023 09:13:37 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing @requires vm.continuations
>> - Initial commit
>
> test/jdk/java/lang/Thread/BuilderTest.java line 294:
>
>> 292: void testPriority3() {
>> 293: Thread currentThread = Thread.currentThread();
>> 294: assumeFalse(currentThread.isVirtual(), "Main test is a virtual thread");
>
> Hello Alan, not specifically related to the changes in this PR, but should that message have been "Main thread ..." instead of "Main test ..."?
Same comment for test methods in `CustomScheduler`
-------------
PR: https://git.openjdk.org/jdk/pull/12426
More information about the serviceability-dev
mailing list