RFR: 8301767: Convert virtual thread tests to JUnit [v2]

Alan Bateman alanb at openjdk.org
Wed Feb 8 09:51:44 UTC 2023


On Wed, 8 Feb 2023 09:22:36 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> test/jdk/java/lang/Thread/BuilderTest.java line 294:
>> 
>>> 292:     void testPriority3() {
>>> 293:         Thread currentThread = Thread.currentThread();
>>> 294:         assumeFalse(currentThread.isVirtual(), "Main test is a virtual thread");
>> 
>> Hello Alan, not specifically related to the changes in this PR, but should that message have been "Main thread ..." instead of "Main test ..."?
>
> Same comment for test methods in `CustomScheduler`

Well spotted. This was a find+replace change so I didn't notice that the original exception message had a typo.

-------------

PR: https://git.openjdk.org/jdk/pull/12426


More information about the serviceability-dev mailing list