RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

Patricio Chilano Mateo pchilanomate at openjdk.org
Tue Feb 21 18:15:26 UTC 2023


On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of nosafepoint.
> The fix includes removal of the function `check_vthread_and_suspend_at_safepoint` which is not needed anymore.
> 
> Testing:
> mach5 jobs are in progress:
>  Kitchensink, tiers1-6 (all JVMTI, JDWP, JDI and JDB tests have to be included)

Looks good to me!

src/hotspot/share/prims/jvmtiThreadState.cpp line 301:

> 299:   }
> 300:   MonitorLocker ml(JvmtiVTMSTransition_lock);
> 301: 

Ah, before we were accessing the vthread oop fields while being blocked so this change actually fixes that.

-------------

Marked as reviewed by pchilanomate (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12550


More information about the serviceability-dev mailing list