RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

Serguei Spitsyn sspitsyn at openjdk.org
Tue Feb 21 19:49:29 UTC 2023


On Tue, 21 Feb 2023 14:45:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiEnv.cpp line 932:
>> 
>>> 930:   JavaThread* current = JavaThread::current();
>>> 931:   HandleMark hm(current);
>>> 932:   Handle self_tobj = Handle(current, nullptr);
>> 
>> This doesn't have to have the assignment, which the compiler will optimize away anyway.
>> 
>> Handle self_tobj;
>> 
>> does the same thing.
>
> Both local variables java_thread and thread_oop should be declared before line 939 so we don't have to worry about the oop being unhandled and java_thread is only used locally.

Thank you, Coleen. Fixed now.

-------------

PR: https://git.openjdk.org/jdk/pull/12550


More information about the serviceability-dev mailing list