RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Thu Jan 5 03:05:51 UTC 2023


On Wed, 4 Jan 2023 09:22:40 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> harmless refactor to share code across different platforms of VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - separate renaming
>  - 8299518: HotSpotVirtualMachine shared code across different platforms

I like the approach in general.
Also, I agree with David on his comments, especially on the renaming.
The abstract methods `readImpl()` and `closeImpl()` is better to name as `read()` and `close()`.

-------------

PR: https://git.openjdk.org/jdk/pull/11823


More information about the serviceability-dev mailing list