RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v4]

Yi Yang yyang at openjdk.org
Mon Jan 9 03:29:05 UTC 2023


On Thu, 5 Jan 2023 04:28:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I was thinking more about describing what the parameters are - in particular it is unclear why the actual IOE can be replaced by a passed in one. If we wanted a custom message then I would at least expect to chain the actual IOE to the replacement.

Done. Parameter ioe means if we get IOE during previous command execution, delay throwing it until command execution completion status has been read. Since all other parameters are straightforward and this is a private method, I don't write  strandard `@param` descriptions for them.

-------------

PR: https://git.openjdk.org/jdk/pull/11823


More information about the serviceability-dev mailing list