RFR: 8299795: Relativize locals in interpreter frames [v4]

[Fredrik Bredberg]

On Wed, 18 Jan 2023 05:07:38 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> My intention was to show how the contents of R18_locals (the absolute address to locals) can be recreated by using R12_scratch2 as an index from the frame pointer. Before we stored R18_locals in the stackframe, now we store R12_scratch2. Does that make more sense?
>
> The code uses &sp()[R12_scratch2]. I think your comment is confusing. Please remove it or write something comprehensive. E.g. save R18_locals in compressed format relative to the new top frame's FP (= current SP).

See what you mean, the R1_SP being the frame pointer is confusing. So how about changing the comment into:
"// Store relativized R18_locals, see frame::interpreter_frame_locals()."
Would that work for you? If not I'll just remove it.

-------------

PR: https://git.openjdk.org/jdk/pull/11902