RFR: 8299795: Relativize locals in interpreter frames [v4]

Martin Doerr mdoerr at openjdk.org
Wed Jan 18 16:01:16 UTC 2023


On Wed, 18 Jan 2023 15:46:22 GMT, Fredrik Bredberg <duke at openjdk.org> wrote:

>> The code uses &sp()[R12_scratch2]. I think your comment is confusing. Please remove it or write something comprehensive. E.g. save R18_locals in compressed format relative to the new top frame's FP (= current SP).
>
> See what you mean, the R1_SP being the frame pointer is confusing. So how about changing the comment into:
> "// Store relativized R18_locals, see frame::interpreter_frame_locals()."
> Would that work for you? If not I'll just remove it.

That's fine. Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/11902


More information about the serviceability-dev mailing list