RFR: JDK-8301070: Replace NULL with nullptr in share/memory/ [v2]
Johan Sjölen
jsjolen at openjdk.org
Thu Jan 26 15:08:40 UTC 2023
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/memory/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>
> Here are some typical things to look out for:
>
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>
> An example of this:
>
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
>
>
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
>
> Thanks!
Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
Fix stefank's comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12185/files
- new: https://git.openjdk.org/jdk/pull/12185/files/def9b5f3..1b09b9a7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12185&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12185&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/12185.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12185/head:pull/12185
PR: https://git.openjdk.org/jdk/pull/12185
More information about the serviceability-dev
mailing list