RFR: JDK-8301070: Replace NULL with nullptr in share/memory/ [v2]

Johan Sjölen jsjolen at openjdk.org
Thu Jan 26 15:08:42 UTC 2023


On Thu, 26 Jan 2023 09:48:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>Small nit. Do we have a unified naming scheme for comments?

Yeah, I forgot to update the PR message with all of the info. If you check now you can see what's been decided upon. The discussions can be found in previous PRs, I can link to them if you're curious.

>"null" reads like a java null. I prefer keeping NULL in comments.

That's true, but this probably can be inferred from context which one is meant quite easily? I'd be more keen on explicitly saying that something is a Java null.

-------------

PR: https://git.openjdk.org/jdk/pull/12185


More information about the serviceability-dev mailing list