RFR: 8311077: Fix -Wconversion warnings in jvmti code [v3]
David Holmes
dholmes at openjdk.org
Mon Jul 3 01:23:10 UTC 2023
On Fri, 30 Jun 2023 12:49:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiRawMonitor.cpp line 385:
>>
>>> 383: OrderAccess::fence();
>>> 384:
>>> 385: int save = _recursions;
>>
>> `_recursions` is `intx`
>
> JvmtiRawMonitor _recursions is an int. Maybe it shouldn't be. You could file an RFE to change that if it's wrong.
>
>
> volatile int _recursions; // recursion count, 0 for first entry
Sorry, yes was looking at the wrong `_recursions`. `int` is fine here, `intx` is odd as the max expected recursions should not depend on 32-bit versus 64-bit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14710#discussion_r1249983979
More information about the serviceability-dev
mailing list