RFR: 8311077: Fix -Wconversion warnings in jvmti code [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Jul 5 12:34:07 UTC 2023


On Mon, 3 Jul 2023 01:20:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> JvmtiRawMonitor _recursions is an int.  Maybe it shouldn't be.  You could file an RFE to change that if it's wrong.
>> 
>> 
>>   volatile int _recursions;     // recursion count, 0 for first entry
>
> Sorry, yes was looking at the wrong `_recursions`. `int` is fine here, `intx` is odd as the max expected recursions should not depend on 32-bit versus 64-bit.

I can't imagine why recursions would be 64 bit in the ObjectMonitor code, that does seem excessive.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14710#discussion_r1253031977


More information about the serviceability-dev mailing list